THREESCALE-8916: Make strong passwords mandatory #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlledom
force-pushed
the
THREESCALE-8916-admin-strong-paswords
branch
from
8c93fc8 to
da18ea7
Compare
jlledom
changed the title
jlledom
changed the title
jlledom
force-pushed
the
THREESCALE-8916-admin-strong-paswords
branch
2 times, most recently
from
33fe198 to
25f4a95
Compare
…le/porta into THREESCALE-12200_clean_up_helpers_0
jlledom
force-pushed
the
THREESCALE-12174-remove-pass-migration
branch
from
0581d50 to
084bfd5
Compare
THREESCALE-12239: Remove unused npm packages
…helpers_0 🧹 Clean up helpers part 0
jlledom
force-pushed
the
THREESCALE-12174-remove-pass-migration
branch
from
525653e to
b6fde4e
Compare
…ass-migration THREESCALE-12174: Remove old password migration
jlledom
force-pushed
the
THREESCALE-8916-admin-strong-paswords
branch
3 times, most recently
from
101f7d4 to
7c97a77
Compare
- Validate strong passwords in React forms - Some forms treat the password field as clear text. - Make password fields required only when they are actually required. - `Current password` field visible and required only when it should. - Password can be set for all users, no matter how did they signup. - SSO Users: don't see the toast to change password. It can be changed from the same form This fixes https://issues.redhat.com/browse/THREESCALE-11548 - When enforce SSO is enabled, passwords can still be set or changed.
jlledom
force-pushed
the
THREESCALE-8916-admin-strong-paswords
branch
2 times, most recently
from
f864657 to
891e8cb
Compare
This is to exclude John Doe from strong passwords validation Co-Authored-By: Claude <noreply@anthropic.com>
jlledom
force-pushed
the
THREESCALE-8916-admin-strong-paswords
branch
from
891e8cb to
35acc2b
Compare
- But skip validation
Let tests fail to get the complete list of outdated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, a provider can enforce strong password for the developer portal, and weak passwords are accepted by default. About admin portal, there's no option to enable strong passwords, weak passwords are always accepted.
I think both situations make no sense. I don't think it's acceptable to allow users decide whether they enforce strong passwords or not, as long as strong passwords are possible, that should be the default. And same thing about admin portal.
In this PR, I remove any option to accept weak passwords in both admin or developer portals. Existing passwords will continue to work, but new passwords will be enforced to be strong. Also, I increased the minimal number of characters to 16.
This affects multiple screens, but also API endpoints, this is the complete list:
Besides, while doing this, I found a few UI errors that I told Claude to fix. This are the affected screens:
Another thing I noticed is strong passwords, even when enabled, were not being enforced for users not created by a human. For instance, the default admin user created when a buyer is created was always accepting weak passwords no matter the setting. I also fixed this.
Which issue(s) this PR fixes
https://issues.redhat.com/browse/THREESCALE-8916
Verification steps
You can go through any (ideally all) screens above an try to set a weak password. Also tests should pass.