feat: added system health configuration to show connected status.#47
Draft
PineappleEmperor wants to merge 1 commit intomainfrom
Draft
feat: added system health configuration to show connected status.#47PineappleEmperor wants to merge 1 commit intomainfrom
PineappleEmperor wants to merge 1 commit intomainfrom
Conversation
Owner
|
Not sure how I missed this.. I can poke around with this too if this is still of interest! |
Collaborator
Author
|
No worries! It was more an exploration of good practice if I'm honest! It's a real shame we can't get the API usage data - that'd make it more worthwhile.. as it stands, connection isn't much to go on - parcel could go down but it's more likely to just indicate internet disconnection! I'm happy to remove the pull request but leave the branch if we ever want to pick it up? What're your thoughts? |
Owner
|
Maybe we migrate this to an issue request? I don't really mind either way, but figured it's blocked until we can get more API stats from parcel. Definitely good with keeping the branch though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jmdevita - discovered system_health, though I'm not sure how worthwhile it is - I've added effectively an 'is connected' entry that can be checked via settings > repairs > three dots > system information.
I THINK if it wasn't connected it might show in repairs.. What I really wanted to do was include info about how many API calls had been made that hour.. but sadly the API doesn't supply that info so we'd have to work out how to count the number of calls in an hour.. which sounds fiddly and difficult =/