Skip to content

Conversation

Copy link

Copilot AI commented Aug 11, 2025

When git-sweep is run in a directory that is not a git repository, it previously showed a technical error message that was not user-friendly:

error: git rev-parse --is-inside-work-tree: exit code 128: exit status 128

This change improves the error handling to detect when the underlying git command fails because we're not in a git repository, and returns the same clear message that Git itself provides:

error: fatal: not a git repository (or any of the parent directories): .git

The fix is minimal and surgical - it only modifies the IsInsideWorkTree function in internal/git/helpers.go to detect the "not a git repository" error in stderr and return an appropriate user-friendly message. All existing functionality remains unchanged, and the tool continues to work normally when run in actual git repositories.

Before:

$ cd /tmp
$ git-sweep
error: git rev-parse --is-inside-work-tree: exit code 128: exit status 128

After:

$ cd /tmp  
$ git-sweep
error: fatal: not a git repository (or any of the parent directories): .git

Fixes #7.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copy link
Author

Copilot AI commented Aug 11, 2025

@jmelosegui 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copilot AI and others added 2 commits August 11, 2025 02:16
Co-authored-by: jmelosegui <450246+jmelosegui@users.noreply.github.com>
…irectory

Co-authored-by: jmelosegui <450246+jmelosegui@users.noreply.github.com>
Copilot AI changed the title [WIP] Improve message when running the sweep in a non repo directory Improve error message when running git-sweep in non-repository directory Aug 11, 2025
Copilot AI requested a review from jmelosegui August 11, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve message when running the sweep in a non repo directory

2 participants