feat: add rolling and expanding sum method #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@jmoralez PR to include expanding and rolling sum |
jmoralez
requested changes
Feb 12, 2025
Owner
jmoralez
left a comment
jmoralez
left a comment
There was a problem hiding this comment.
Thanks, just a small comment. Also, can you please update the notebooks? The code is produced the other way around, you update the notebook and then export the python files.
|
|
||
| @njit | ||
| @_rolling_docstring | ||
| def rolling_sum(input_array: np.ndarray, window_size: int, min_samples: int | None = None) -> np.ndarray: |
Owner
There was a problem hiding this comment.
This is python 3.10+ syntax
Suggested change
| def rolling_sum(input_array: np.ndarray, window_size: int, min_samples: int | None = None) -> np.ndarray: | |
| def rolling_sum(input_array: np.ndarray, window_size: int, min_samples: Optional[int] = None) -> np.ndarray: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.