Skip to content

Conversation

@joshStillerman
Copy link

Thank you for providing this great package. I have made some small updates, expanded the test program to talk to real cameras, and added a setup.py so it can be on Pypi.

I am going to put this version on Pypi but will happily take it down if you merge this and put it up yourself.

@amcdawes
Copy link

This sounds great, and thank you for getting it put together for PyPi packaging. I have also made quite a few changes on my own fork (https://github.com/DawesLab/PythonForPicam), I don't see any overlap off the top of my head but I need to get better with git to check for conflicts. I'll take a closer look at these changes here and try them out in my lab on Monday. I don't know how active this original repo is but I'm happy to help you keep this code working.

@joshStillerman
Copy link
Author

Thanks -
I having some trouble getting it onto pypi - not sure why yet, will
probably send an update to setup.py. It would be great if there was one
master copy that has the best bits of all of the versions.

-Josh

On 6/18/16 11:21 AM, Andrew M. C. Dawes wrote:

This sounds great, and thank you for getting it put together for PyPi
packaging. I have also made quite a few changes on my own fork
(https://github.com/DawesLab/PythonForPicam), I don't see any overlap
off the top of my head but I need to get better with git to check for
conflicts. I'll take a closer look at these changes here and try them
out in my lab on Monday. I don't know how active this original repo is
but I'm happy to help you keep this code working.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHHQZY-CffOkBwTRNMuaJfA-O-48p_UGks5qNAzcgaJpZM4I4kOa.

@amcdawes
Copy link

I agree, and that should be the version linked from Pypi. The main changes I made were to run under Linux so at least adding some platform detection steps would be good too.

Andy

Sent from my phone using voice-recognition software and/or clumsy thumbs, please forgive any typos.

On Jun 18, 2016, at 8:55 AM, Josh Stillerman notifications@github.com wrote:

Thanks -
I having some trouble getting it onto pypi - not sure why yet, will
probably send an update to setup.py. It would be great if there was one
master copy that has the best bits of all of the versions.

-Josh

On 6/18/16 11:21 AM, Andrew M. C. Dawes wrote:

This sounds great, and thank you for getting it put together for PyPi
packaging. I have also made quite a few changes on my own fork
(https://github.com/DawesLab/PythonForPicam), I don't see any overlap
off the top of my head but I need to get better with git to check for
conflicts. I'll take a closer look at these changes here and try them
out in my lab on Monday. I don't know how active this original repo is
but I'm happy to help you keep this code working.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHHQZY-CffOkBwTRNMuaJfA-O-48p_UGks5qNAzcgaJpZM4I4kOa.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@joelowney
Copy link
Owner

Hi Josh and Andy,

I'm happy to hear that this code is being used still. I haven't looked at
this code in years, but if I need to do something with my github account or
something just let me know, I'd be happy to help. I really don't know how
to use github, so please forgive my incompetency there -- just let me know
what you need me to do.

Best Regards,
Joe

On Sat, Jun 18, 2016 at 11:04 AM Andrew M. C. Dawes <
notifications@github.com> wrote:

I agree, and that should be the version linked from Pypi. The main changes
I made were to run under Linux so at least adding some platform detection
steps would be good too.

Andy

Sent from my phone using voice-recognition software and/or clumsy thumbs,
please forgive any typos.

On Jun 18, 2016, at 8:55 AM, Josh Stillerman notifications@github.com
wrote:

Thanks -
I having some trouble getting it onto pypi - not sure why yet, will
probably send an update to setup.py. It would be great if there was one
master copy that has the best bits of all of the versions.

-Josh

On 6/18/16 11:21 AM, Andrew M. C. Dawes wrote:

This sounds great, and thank you for getting it put together for PyPi
packaging. I have also made quite a few changes on my own fork
(https://github.com/DawesLab/PythonForPicam), I don't see any overlap
off the top of my head but I need to get better with git to check for
conflicts. I'll take a closer look at these changes here and try them
out in my lab on Monday. I don't know how active this original repo is
but I'm happy to help you keep this code working.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/joelowney/PythonForPicam/pull/2#issuecomment-226947951>,

or mute the thread
<
https://github.com/notifications/unsubscribe/AHHQZY-CffOkBwTRNMuaJfA-O-48p_UGks5qNAzcgaJpZM4I4kOa
.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACt3gWv2z8hSebxoi3npWgJEC4Ud_sAUks5qNDM9gaJpZM4I4kOa
.

Add URL, change email, remove trailing comma from Platforms
@joshStillerman
Copy link
Author

This is the same as the previous pull request with some changes to setup.py so that it will upload to Pypi

Sorry I did not know how to tell it to just include the 1 changed file.

@thomasrbharris
Copy link

As a note to anyone involved in this repository or stumbling upon it in the future, as of very recently (January 2021) there is an "official" GitHub repository called SpeReadPy supported by Teledyne Princeton Instruments (TPI) that hosts Python code for interfacing with Lightfield, parsing .spe files, and (most relevant!) controlling PICam. The person who created the repository, Sabbir Liakat of TPI, welcomes people to share their Pythonic PICam implementations or examples there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants