Conversation
joeltankam
requested changes
Oct 12, 2018
Owner
joeltankam
left a comment
joeltankam
left a comment
There was a problem hiding this comment.
Some fixes needed.
Update Readme.md and make sure all Codacy tests pass.
| { | ||
| "name": "checkif.js", | ||
| "version": "0.0.1", | ||
| "version": "0.3.1", |
Owner
There was a problem hiding this comment.
The package-lock.json should not be updated. Please pull the repository before applying your changes
| return value != null && typeof value === 'object' && 'setInterval' in value; | ||
| } | ||
|
|
||
| /** |
Owner
There was a problem hiding this comment.
This should not be done in this file, but in regexp.jsas mentioned in the issue.
Check out @boristane pull request #40
| */ | ||
| export function isEmail(value) { | ||
| /* eslint-disable-next-line no-useless-escape */ | ||
| const re = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/; |
| expect(is.email('very.common@example.com')).toBeTruthy(); | ||
| expect(is.email('other.email-with-hyphen@example.com')).toBeTruthy(); | ||
| expect(is.email('user.name+tag+sorting@example.com')).toBeTruthy(); | ||
| }); |
Owner
There was a problem hiding this comment.
Please add more tests (specifications mentioned in the wikipedia page)
| }); | ||
| test('returns false', () => { | ||
| expect(is.email('john..doe@example.com')).toBeFalsy(); | ||
| }); |
Owner
There was a problem hiding this comment.
Please add more tests (specifications mentioned in the wikipedia page)
Owner
|
Please apply the requested changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please let me know if this helps
closes issue 23