Add provider object to api endpoint #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optional provider object gives detailed information about the application serving up the endpoints. Move name and logo properties into new provider object.
Make name property of provider required if provider is present. Remove provider type property as superfluous. Change description of provider build date to Timestamp instead of TIME.
It was suggested that build_date can be part of the provider version string. It was agreed that having any URL in the provider object is unnecessary; knowing the provider should be enough information to track down any documentation you may need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional provider object gives detailed information about the application serving up the endpoints. Move name and logo properties into the new provider object.