Open
Conversation
Contributor
|
❤️ |
Contributor
|
@johncarl81 thoughts on merging to master? |
Owner
Author
|
I have a couple changes I made recently to be able to publish this on maven central. I have a couple other tweaks to make, mainly to accommodate other libraries that use the base. Then it's time for prime time. |
Contributor
|
great.. do those changes change anything about the usage as I know it right now? |
Owner
Author
|
They may affect how you reference the rbridge library. |
Owner
Author
|
Ok @dbachelder, could you review the latest changes? |
Contributor
|
@johncarl81 I like that you've moved it into TF proper.. would you mind pushing this up as the snapshot release and I'll try it one more time before we merge it? |
Owner
Author
|
Sure, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android libraries use
Rclasses withoutpublic static final(http://tools.android.com/tips/non-constant-fields):This means you can't reference these fields from an annotation as there are not considered constants. The previous alternative was to use tags, which looses compile time checking. This PR gives an alternative way...
This PR adds a secondary annotation processor to generate a R class with
public static finalanalogies for librarypublic finalnon-static. Transfuse, in turn, recognizes these analogies and swaps in the original R library identifier. The only requirement is to annotate your source with theBridgeannotation:Then you may use
RBridgeinstead ofRin any Transfuse annotation: