Skip to content

Conversation

@owenvoke
Copy link

  • Updated to PSR-2
  • Updated to PSR-4
  • Updated to support PHP 7
  • Updated PhpDoc comments

@johncave
Copy link
Owner

This is some great work, but there's a couple of issues before I can use this refactor in production.

In table.html.php, every reference to a configuration element seems to be wrong.
PHP message: PHP Notice: Undefined index: TORRENT_DIR in /var/www/html/phplinuxtrack/templates/table.html.php on line 51
(it's TORRENT_DIRECTORY in .env.example)
PHP message: PHP Notice: Undefined index: TORRENT_WEB_DIR in /var/www/html/phplinuxtrack/templates/table.html.php on line 91
(it's TORRENTS_WEB_DIR in .env.example)
You can probably just change .env.example itself.

Also, the actual torrent numbers / details absolutely have to be loaded asynchronously (bittorrent trackers are generally very slow to respond), otherwise after more than one or two torrents are in the system, the entire page loads at an unusable speed on runs that have any torrents on public trackers not in cache. We'll need the loading gif and / or "please wait while we check torrent status" back.

Thanks for all your work!

@owenvoke
Copy link
Author

@johncave that should be fixed in the commit I just did. Cheers.

I'll try and add back in the AJAX. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants