-
Notifications
You must be signed in to change notification settings - Fork 1
Composer Updates & PSR-2/4 changes #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
owenvoke
commented
Jun 30, 2017
- Updated to PSR-2
- Updated to PSR-4
- Updated to support PHP 7
- Updated PhpDoc comments
It now also loads the config into the environment
|
This is some great work, but there's a couple of issues before I can use this refactor in production. In table.html.php, every reference to a configuration element seems to be wrong. Also, the actual torrent numbers / details absolutely have to be loaded asynchronously (bittorrent trackers are generally very slow to respond), otherwise after more than one or two torrents are in the system, the entire page loads at an unusable speed on runs that have any torrents on public trackers not in cache. We'll need the loading gif and / or "please wait while we check torrent status" back. Thanks for all your work! |
|
@johncave that should be fixed in the commit I just did. Cheers. I'll try and add back in the AJAX. 👍 |