Client: clickmanager, maplebutton, maplestancebutton, mapleframebutton#7
Open
sedyn wants to merge 2 commits intojohncintron:masterfrom
Open
Client: clickmanager, maplebutton, maplestancebutton, mapleframebutton#7sedyn wants to merge 2 commits intojohncintron:masterfrom
sedyn wants to merge 2 commits intojohncintron:masterfrom
Conversation
johncintron
reviewed
Jun 10, 2018
src/client/clickmanager.js
Outdated
| return; | ||
| } | ||
|
|
||
| for (let button of buttons) { |
Owner
There was a problem hiding this comment.
You should use for (const. This also applies to lines 46 and 58.
johncintron
requested changes
Jun 10, 2018
Owner
johncintron
left a comment
johncintron
left a comment
There was a problem hiding this comment.
Why does this PR break the login button? By that I mean hovering over it or clicking it has no effect.
Hint: there's something wrong with MapleStanceButton and getRect.
Contributor
Author
|
@johncintron Thank you for review. I fixed problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implement new features.