I never could finish studying neither practicing#69
Open
Nora79 wants to merge 1 commit intojoinpursuit:masterfrom
Open
I never could finish studying neither practicing#69Nora79 wants to merge 1 commit intojoinpursuit:masterfrom
Nora79 wants to merge 1 commit intojoinpursuit:masterfrom
Conversation
| * returns { 99: 2, 11: 1, 12: 1, 13: 1, 58: 1 } | ||
| */ | ||
|
|
||
| function countNumbers() { |
There was a problem hiding this comment.
This function should take in a parameter as indicated on line 5. So, we need to be mindful to include the parameter in the parenthesis of the function.
| let countNumbers = { }; | ||
| for (let i = 0; i < arr.length; i++) { | ||
| value = arr[i] | ||
| if (typeof countNumbers[value] === "undefined") { |
There was a problem hiding this comment.
Do we need to use typeof to figure out if a key/value pair exists in an object?
| countryPopulations.sort(function (a, b) { | ||
| return b.population - a.population; | ||
| //should return ['China', 'Egypt', 'Denmark'] only from the object??????!!! | ||
| }); |
There was a problem hiding this comment.
This is a great start! Which array method can we chain here that will allow us to return an array with just the information we need?
| */ | ||
| let n = 4; | ||
| function isOdd(n){ | ||
| if(n %2 === 1){ |
There was a problem hiding this comment.
Do we need an if-else statement here? Explore implicit return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.