Skip to content
This repository was archived by the owner on Jul 28, 2020. It is now read-only.

Conversation

@davidnguyen-joomlashine
Copy link

Pull Request for Issue #173 .

Summary of Changes

Add 'j-card', 'j-card-header', 'j-card-body' block styles on all tabs

Testing Instructions

Expected result

Actual result

Documentation Changes Required

@C-Lodder
Copy link
Contributor

C-Lodder commented Jan 3, 2020

You are killing accessibility by replacing the <legend> with a <div>.

https://www.w3.org/TR/WCAG20-TECHS/H71.html#H71-description

The first element inside the fieldset must be a legend element, which provides a label or description for the group

@brianteeman
Copy link
Contributor

Exactly what @C-Lodder says.

@davidnguyen-joomlashine
Copy link
Author

Thanks for your comments. I inherit code from Global Configuration (https://recordit.co/i3JGWh8yrj) to show configure consistently on all tabs. Should we fix for 'Article' tab issue show as 'Global Configuration' tab? Thank you

@brianteeman
Copy link
Contributor

Unfortunately the code in global configuration that you show here is also wrong. The layout being used layouts\joomla\content\options_default.php has been changed in this repo to completely break accessibility. Not your fault. It's just plain wrong. Despite a requirement and a commitment to make this accessible once again we see accessibility being broken.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants