This repository was archived by the owner on Sep 23, 2021. It is now read-only.
Workaround issue #97 by copying cmd.exe into the temporary folder and running it from here#129
Open
zvin wants to merge 2 commits intojorangreef:masterfrom
Open
Conversation
…folder and running it from here
zvin
force-pushed
the
workaround-windows-amperstand-in-username
branch
from
1434944 to
81cab70
Compare
Owner
|
Thanks @zvin ! It's an ugly (but beautiful) hack... It looks good, but would you please make the copy conditional on there being an ampersand in the path? This way, the common case is not affected by the copy, and we may also avoid knock-on bugs. |
Owner
Author
|
@jorangreef Added, I hope I didn't forget any |
Author
|
This second commit was very wrong, it avoids copying but still runs cmd from the tmp path, I'll fix that. |
zvin
force-pushed
the
workaround-windows-amperstand-in-username
branch
from
f23153e to
687e194
Compare
Author
|
PR updated @jorangreef |
zvin
force-pushed
the
workaround-windows-amperstand-in-username
branch
from
687e194 to
7cdede2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jorangreef
There's been no activity on #97 or microsoft/terminal#2419 for a year so I came up with a (quite ugly) workaround.
Since the issue is with escaping the
execute.batfile path, I copycmd.exein the temporary folder and run it from here.It avoids dealing with the path completely.
cmd.exeis ~274KiB so it isn't taking too long to copy.I acknowledge this is ugly but I couldn't find anything better.