fixes to enable s3 and postgres use #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svozza
force-pushed
the
add-backend-deps
branch
from
e109edb to
d106caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you're still maintaining this but it's a great resource that I've found very useful due to the ability to set config using environment variables. In order to get it working though I had to make a few changes because there were missing dependencies for the postgres backend. I also removed the
AWS*keys because it forced users to provide keys rather than IAM roles (the old behaviour can still work by providing those env vars independent of Pypicloud so there's no need for them to be in the Docker file). I also updated the version ofconfdfrom the alpha version that was being used.