fix: add retry for config-dependent tests on macOS CI#106
Merged
Conversation
The configuration test suite modifies workspace settings between tests. On macOS CI, config restoration in teardown may not fully propagate before the next test's search begins. Adding this.retries(2) as a safety net for these timing-sensitive config-dependent searches.
Contributor
|
✅ Tests passed on ubuntu-latest |
Contributor
|
✅ Tests passed on macos-latest |
Contributor
|
✅ Tests passed on windows-latest |
Contributor
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
this.retries(2)to the Configuration test suite to handle non-deterministic config propagation timing on macOS CIContext
Follow-up to PR #105. The readiness gate fixed 11 of 12 flaky macOS failures. The remaining failure (
finds content when exclusion is removedinconfiguration.test.ts) occurs because config restoration inteardown()hasn't fully propagated before the next test's search begins on slower macOS CI runners.Test plan