fix: apply smart-case behavior to searchFiles glob patterns#107
Merged
fix: apply smart-case behavior to searchFiles glob patterns#107
Conversation
Ripgrep's --smart-case flag only affects regex pattern matching, not --glob patterns used by searchFiles. This caused lowercase file name queries (e.g. "dockerfile") to return no results when --smart-case was enabled, even though a file named "Dockerfile" existed. Fix by using --iglob (case-insensitive glob) when --smart-case is set and the query is all lowercase, and --glob when the query contains uppercase characters. Also handles --ignore-case and --case-sensitive flags appropriately.
Contributor
|
✅ Tests passed on ubuntu-latest |
Contributor
|
✅ Tests passed on macos-latest |
Contributor
|
✅ Tests passed on windows-latest |
Contributor
|
🎉 This PR is included in version 1.16.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #104
--smart-caseflag only affects regex pattern matching, not--globpatterns used bysearchFiles. This caused lowercase file name queries (e.g.dockerfile) to return no results even when a file namedDockerfileexisted.--iglob(case-insensitive glob) when--smart-caseis set and the query is all lowercase, and--globwhen it contains uppercase characters.--ignore-caseand--case-sensitiveflags appropriately.Test plan
searchFileswith--smart-casefindsDockerfilevia lowercase querydockerfilesearchFileswith--smart-casefindsDockerfilevia mixed-case queryDockerDockerfilefixture attest/fixtures/workspace/build/"periscope.rgOptions": ["--smart-case"], runperiscope.searchFiles, typedockerfile→ should findDockerfile