feat(results): add option to show line numbers#97
Merged
joshmu merged 1 commit intojoshmu:masterfrom Aug 31, 2025
Merged
Conversation
jimeh
changed the title
jimeh
force-pushed
the
show-line-number
branch
from
e7b48e0 to
2962393
Compare
Contributor
Author
|
Seems CI is failing on the "Update PR Status" step, but the tests did run successfully. |
jimeh
force-pushed
the
show-line-number
branch
from
2962393 to
a087cec
Compare
Contributor
Author
|
@joshmu Thanks for the feedback, apologies for the delay in getting back to this, been a busy couple of weeks... lol I've made |
- Introduced a new configuration option `periscope.showLineNumbers` to control the display of line numbers alongside file paths in search results. It defaults to `true`. - Updated `formatPathLabel` to append line numbers when `showLineNumbers` is enabled. - Enhanced tests to verify line number functionality in various scenarios.
jimeh
force-pushed
the
show-line-number
branch
from
a087cec to
fc46707
Compare
joshmu
approved these changes
Aug 31, 2025
Contributor
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
joshmu
added a commit
that referenced
this pull request
Aug 31, 2025
- Integrated showLineNumbers configuration option - Resolved conflicts by keeping new test architecture - Line number feature now available in formatPathLabel utility
joshmu
added a commit
that referenced
this pull request
Aug 31, 2025
…ecture Merged PR #97 line numbers feature into the new test architecture. Updated default showLineNumbers to true, added comprehensive test coverage across quickPick, search, and configuration suites, and fixed config test to use withConfiguration helper for proper cleanup.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 31, 2025
# [1.15.0](v1.14.0...v1.15.0) (2025-08-31) ### Bug Fixes * **editor:** remove unnecessary async edit in setCursorPosition ([018dce6](018dce6)) * **search:** restore dynamic --files flag detection in query ([35140f5](35140f5)) * **test:** increase Windows CI timeout multiplier to 3x for stability ([f4124e2](f4124e2)) * **test:** normalize startFile paths for cross-platform compatibility ([456d92b](456d92b)) * **test:** prevent settings.json modifications after test runs ([cfa6a61](cfa6a61)) * **test:** remove color overrides causing config test failures ([0168064](0168064)) * **test:** resolve CI race condition in file search mode test ([27283d7](27283d7)) * **test:** resolve failing escape key test with proper editor state setup ([596368c](596368c)) * **test:** resolve flaky preview tests and enhance waitForPreviewUpdate helper ([4b3518b](4b3518b)) * **test:** resolve Windows CI test failures ([5da81c2](5da81c2)) * **tests:** simplify wait time calculation for CI-aware timeouts ([e6145b0](e6145b0)) ### Features * implement file search with improved architecture ([#89](#89)) ([43ae1b2](43ae1b2)) * merge master branch with line numbers feature from PR [#97](#97) ([5ebe3cd](5ebe3cd)) * **search:** add injectable arguments for flexible ripgrep configuration ([b119b2e](b119b2e)) * **search:** integrate line numbers feature with updated test architecture ([4b4e929](4b4e929)) * **test:** add CI-aware timeout multipliers ([dbfbb3e](dbfbb3e)) * **test:** add single test execution capabilities ([d92b208](d92b208)) * **test:** fix configuration exclusion test and improve test helper ([34c3e72](34c3e72)) ### Performance Improvements * **test:** reduce test execution time by 58% with optimized timeouts ([7cae1a4](7cae1a4))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
periscope.showLineNumbersto control the display of line numbers alongside file paths in search results. It defaults tofalseto retain existing behavior.formatPathLabelto append line numbers when enabled.This is is my second ever tango with TypeScript, so feel free to criticize anything you might be unhappy with. I'm more than happy for feedback and to fix things :)
Screenshot