Skip to content

Updated the width prop to include more valid CSS values. #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JapMul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated the width prop to include more valid CSS values. #210

JapMul wants to merge 1 commit into from

Conversation

@JapMul
Copy link

@JapMul JapMul commented Feb 13, 2018

Description of changes:
Enhances the width prop of the lightbox component. After this commit, the property accepts the width value as a plain number, numbers with a px, vw or % suffix, none, inherit and initial.

Related issues (if any):
Fixes #165

Checks:

  • Please confirm yarn run lint ran successfully
  • Please confirm that only /src and /examples/src are committed
  • [if new feature] Please confirm that documentation was added to the README.md

@davwheat davwheat mentioned this pull request Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accept string values for width

1 participant

@JapMul