Optimize ComposedLinearOperator materialisation and as_matrix#2
Open
jpbrodrick89 wants to merge 1 commit intomainfrom
Open
Optimize ComposedLinearOperator materialisation and as_matrix#2jpbrodrick89 wants to merge 1 commit intomainfrom
jpbrodrick89 wants to merge 1 commit intomainfrom
Conversation
- Add identity shortcuts: Identity @ X returns X, X @ Identity returns X - Use vmap over operator1.mv instead of matmul for as_matrix, enabling efficient composition when operator1 has O(N) mv (e.g., Diagonal) https://claude.ai/code/session_0143xm3Fot5bh7Zy3GfkP6bD
jpbrodrick89
force-pushed
the
claude/explore-operator-colouring-57ptE
branch
from
c904e26 to
06a0469
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add compose rules in materialise() for Diagonal/Tridiagonal combinations:
Update as_matrix() to delegate to materialise() first, falling back to
vmap over operator1.mv for O(N²) instead of O(N³) when operator1 has
efficient mv.
https://claude.ai/code/session_0143xm3Fot5bh7Zy3GfkP6bD