Structural changes and new functionality #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add setup.py file for package info. Now able to install package with …
- modified groups.py to retrive UUID of an OG via groupid
…s that the endpoint is in MDM so that a stupid thing. updated client.py and setup.py for some of the changes removed jheader from create method in groups.py
added methods to groups.py to help with ldap configuration
- renamed a function to be more consistant - reworked some string manipulation ot be consistant - added 3 function for getting security infor sample info - added function to retrevie jsut FIleVault Key
- Stagging flow for none AD - Added Patch to MDM - Added Patch to client
# Conflicts: # pyairwatch/client.py # pyairwatch/mdm/devices.py
…any environment details.
- renamed some functions for read ability - made small changes for conventions i created elsewhere
- removed jheader that wasn't used tags.py - following convention
deltakhan
changed the title
moved the error class out to it's own file
jprichards
reviewed
Apr 24, 2020
pyairwatch/system/users.py
Outdated
| """POST requests for the /System/Users module.""" | ||
| response = self.client.post(module=module, path=path, version=version, params=params, data=data, json=json, header=header) | ||
| return response | ||
| def create_device_regestration_to_user(self, user_id, register_device_details): |
Owner
There was a problem hiding this comment.
typo in "regestration"
Suggested change
| def create_device_regestration_to_user(self, user_id, register_device_details): | |
| def create_device_registration_to_user(self, user_id, register_device_details): |
pyairwatch/system/admins.py
Outdated
| def _post(self, module='system', path=None, version=None, params=None, data=None, json=None, header=None): | ||
| """POST requests for the /System/Admins module.""" | ||
| response = self.client.post(module=module, path=path, version=version, params=params, data=data, json=json, header=header) | ||
| def create_adim_v1(self, user_data): |
Owner
There was a problem hiding this comment.
typo in "adim"
Suggested change
| def create_adim_v1(self, user_data): | |
| def create_admin_v1(self, user_data): |
added 3 commits
April 24, 2020 09:36
- Device Delete added - removed some duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So many changes please take a look