Warning about componentWillReceiveProps
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References jsdir#61 As mentioned in React docs [here](https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops) `componentWillReceiveProps` is being deprecated, and should be either renamed to `UNSAFE_componentWillReceiveProps` or be replaced with `componentDidUpdate`.
… pass test cases`
cube-dan
added a commit
to perfectcube/react-ladda
that referenced
this pull request
Nov 14, 2019
…/react-ladda.git#master“ will work out of the box. this is a stopgap until pr jsdir#62 is finalized and released on npm by jsdir/react-ladda
|
Is anyone still maintaining this project? I see no reason not to merge this PR. |
|
^ Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #61
As mentioned in React docs here
componentWillReceivePropsis being deprecated, and should be either renamed toUNSAFE_componentWillReceivePropsor be replaced withcomponentDidUpdate.