fix: use parity-aware regex to handle escaped backslashes in JSON str… #2030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix / Refactoring.
Issue Number:
Closes #2013
Summary:
This PR provides a robust, performance-optimized fix for the JSON string parsing issue where trailing escaped backslashes (e.g., "\\") break the editor's syntax highlighting.
Technical Advantage over other proposals:
Unlike solutions using manual character-counting loops, this PR implements a parity-aware regex lookbehind: (?<=(^|[^])(?:\)*)".
Efficiency:
It leverages the native V8/C++ regex engine, which is more performant than manual JavaScript loops for large payloads.
Maintainability:
It solves the problem at the regex definition level, keeping the core parsing logic clean and declarative.
Improved Coverage:
It also updates regexString to ensure that full-string matches are correctly identified when they contain escaped backslashes.