Skip to content

UriValidator file: tests/fix(es) #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alcohol wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UriValidator file: tests/fix(es) #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/JsonSchema/Tool/Validator/UriValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public static function isValid(string $uri): bool

// RFC 3986: Non-Hierarchical URIs (mailto, data, urn, news)
$nonHierarchicalPattern = '/^
(mailto|data|urn|news|tel): # Only allow known non-hierarchical schemes
(mailto|data|urn|news|tel|file): # Only allow known non-hierarchical schemes
(.+) # Must contain at least one character after scheme
$/ix';

Expand Down
5 changes: 5 additions & 0 deletions tests/Tool/Validator/UriValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ public function validUriDataProvider(): \Generator
yield 'OASIS URN URI' => ['uri' => 'urn:oasis:names:specification:docbook:dtd:xml:4.1.2'];
yield 'Custom URI with underscore' => ['uri' => 'custom://reg_name/path/file.json'];
yield 'Custom URI with tilde' => ['uri' => 'custom://reg~name/path/file.json'];
yield 'File URI with implicit localhost (empty host)' => ['uri' => 'file:///path/to/file.txt'];
yield 'File URI with explicit host' => ['uri' => 'file://some-host/path/to/file.txt'];
yield 'File URI without any host' => ['uri' => 'file:/path/to/file.txt'];
}

public function invalidUriDataProvider(): \Generator
Expand All @@ -47,5 +50,7 @@ public function invalidUriDataProvider(): \Generator
yield 'Invalid path characters with "^"' => ['uri' => 'http://example.com/^invalid'];
yield 'Only mailto:' => ['uri' => 'mailto:'];
yield 'Invalid email used in mailto:' => ['uri' => 'mailto:user@.com'];
// Cannot be validated properly with regex only
// yield 'Invalid file uri (missing host)' => ['uri' => 'file://path/to/file.txt'];
}
}