Skip to content

Implement eslint and lint codebase#112

Merged
jtebbens merged 7 commits intojtebbens:masterfrom
DCSBL:DCSBL-2025-135
Mar 9, 2025
Merged

Implement eslint and lint codebase#112
jtebbens merged 7 commits intojtebbens:masterfrom
DCSBL:DCSBL-2025-135

Conversation

@DCSBL
Copy link

@DCSBL DCSBL commented Mar 9, 2025

Continuing on #83

You thought #110 was big.. that was nothing...:

This PR:

  • Implements eslint via the default config of https://github.com/athombv/eslint-config-athom
  • Removes prettier (as this has conflicting rules, and was not used in CI)
  • Adds a pre-commit-config file; Install pre-commit, and run pre-commit install. This runs some quick checks before each commit to prevent 'invalid' commits. Can be ignored via --no-check flag per commit or even not installed at all.

Real changes:

  • package.json has a new 'scripts' to run eslint + addition of devDependencies
  • Addition of pre-commit-config.yaml
  • Updated eslintrc.json to use athoms style settings
  • Updated validate.json to validate the change for each PR

The rest are auto-updated via eslint.

All non auto-fixable rules are disabled in eslintrc.json, and can be enabled step by step.

@jtebbens
Copy link
Owner

jtebbens commented Mar 9, 2025

You are outmatching my coding skills. Lol

@DCSBL DCSBL marked this pull request as draft March 9, 2025 14:31
@DCSBL DCSBL marked this pull request as ready for review March 9, 2025 14:35
@DCSBL
Copy link
Author

DCSBL commented Mar 9, 2025

Hah, this is just some copy-pasta. I have no idea what I am doing actually 😇

@jtebbens jtebbens merged commit c78a2b5 into jtebbens:master Mar 9, 2025
2 checks passed
@DCSBL DCSBL mentioned this pull request Mar 9, 2025
@DCSBL DCSBL deleted the DCSBL-2025-135 branch March 9, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants