Skip to content

Fixing tests after the DAP Debugger.#2

Merged
jtulach merged 1 commit intojtulach:lsp_client_dapfrom
jlahoda:lsp_client_dap.fixes
Dec 30, 2024
Merged

Fixing tests after the DAP Debugger.#2
jtulach merged 1 commit intojtulach:lsp_client_dapfrom
jlahoda:lsp_client_dap.fixes

Conversation

@jlahoda
Copy link

@jlahoda jlahoda commented Dec 30, 2024

I was looking at apache#8098 - good job!

This PR:

  • fixes the paperwork task, by adding license headers (assuming you'll agree with them)
  • fixes the ConnectionSpecTest, by handling the ending newline
  • making the resume method perform continue, which was missing ("step" methods already do that).

Please let me know what you think!

@jtulach jtulach merged commit 7504509 into jtulach:lsp_client_dap Dec 30, 2024
24 of 28 checks passed
@jtulach
Copy link
Owner

jtulach commented Dec 30, 2024

Thanks a lot for your help! I am glad I am not alone in this endeavor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments