Open
Conversation
psteinb
reviewed
Jun 24, 2020
| } | ||
| ], | ||
| "source": [ | ||
| "# Here we just load a single image and inspect the dimensions.\n", |
There was a problem hiding this comment.
Sorry for jumping in. I was curious and couldn't resist reading this in diagonal.
Here we just load a single image and inspect the dimensions.
I'd remove fill words like 'just' here.
For people not familiar with numpy or PIL.Image this single just can be received in a demotivating fashion, i.e. for someone that doesn't understand np.array(Image.open('data/longBeach.png')) at plain sight is likely to feel incompetent by means of the implications behind just. ;) This feeling is something you don't want in the first notebook they read through when learning n2v.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve Issues #49 and #66.