Add a Tracker class to support aggregate-worst case consumption delay…#3
Open
Add a Tracker class to support aggregate-worst case consumption delay…#3
Conversation
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
jugomezv
force-pushed
the
jugomez/PinotIngestionDelay
branch
2 times, most recently
from
d73a8ed to
7d485e6
Compare
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
mcvsubbu
reviewed
Dec 13, 2022
...core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
Outdated
Show resolved
Hide resolved
...ent-local/src/main/java/org/apache/pinot/segment/local/utils/tablestate/TableStateUtils.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java
Outdated
Show resolved
Hide resolved
mcvsubbu
reviewed
Dec 13, 2022
mcvsubbu
left a comment
mcvsubbu
left a comment
There was a problem hiding this comment.
still partial review. will finish later today
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Outdated
Show resolved
Hide resolved
… in Pinot Early draft for review, no significant unitest or end to end testing done yet. Missing: code to read ideal state, unitets. -Changed code to not remove but verify a partition when CONSUMING to OFFLINE transition comes Tests: make sure server, core tests pass. -Added support for reading ideal state -Added some unitests for tracker object -Added more unitests that deal with partition removal. -Removed caching the maximum to simplefy the code. -Use Concurrent hashes instead of synchronized methods.
jugomezv
force-pushed
the
jugomez/PinotIngestionDelay
branch
from
7d485e6 to
c866f95
Compare
mcvsubbu
reviewed
Dec 13, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 19, 2022
.../src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 19, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 19, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 19, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 19, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 19, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 19, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 19, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 19, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 20, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 20, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
gviedma
reviewed
Dec 20, 2022
...in/java/org/apache/pinot/core/data/manager/realtime/MaximumPinotConsumptionDelayTracker.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in Pinot
Early draft for review, no significant unitest or end to end testing done yet.
Missing: code to read ideal state, unitets.
featuretesting: made sure that we do not break any of the existing server tests:[INFO] Results:
[INFO]
[INFO] Tests run: 29, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
release-notesNew metric for consumption delay.