fix(object-authorization): Fix object authorization for interfaces#42
Open
tcitworld wants to merge 1 commit intojungsoft:masterfrom
Open
fix(object-authorization): Fix object authorization for interfaces#42tcitworld wants to merge 1 commit intojungsoft:masterfrom
tcitworld wants to merge 1 commit intojungsoft:masterfrom
Conversation
Very similar to jungsoft#26, but for interfaces instead of unions Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Member
|
Hey @tcitworld, thank you for this PR! However, I don't think interfaces should work exactly like Unions, because we can't always infer the authorization rules from the underlying types. It works well on your example, but it would not work for a query that fetches only common fields, since in this case we wouldn't have So let's say interface :interface do
field :id, :integer
resolve_type fn
%{name: _}, _ -> :user
%{total: _}, _ -> :wallet_balance
end
endIf we fetch only this id, the query would be allowed without any authorization checks: Therefore, I think we need to force users to define a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very similar to #26, but for interfaces instead of unions