Disable LexicographicalAnnotationAttributeListing#5043
Merged
marcphilipp merged 1 commit intojunit-team:mainfrom Oct 13, 2025
Merged
Conversation
Pankraz76
force-pushed
the
LexicographicalAnnotationListing--extend-errorprone
branch
from
d106e13 to
f68b088
Compare
Pankraz76
commented
Oct 9, 2025
junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/execution/DefaultTestInstances.java
Outdated
Show resolved
Hide resolved
junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvFileSource.java
Outdated
Show resolved
Hide resolved
This was referenced Oct 9, 2025
Pankraz76
changed the title
error-prone.picnic.tech featuring Lexicographical & StaticImportLexicographicalAnnotationAttributeListing
Pankraz76
force-pushed
the
LexicographicalAnnotationListing--extend-errorprone
branch
from
f68b088 to
afcad28
Compare
marcphilipp
requested changes
Oct 13, 2025
Member
marcphilipp
left a comment
marcphilipp
left a comment
There was a problem hiding this comment.
I think this rules does more harm than good. Could you please disable it explicitly (after rebasing on main) with a comment?
| } | ||
|
|
||
| @Category({ "JUnit", "Discovery" }) | ||
| @Category({ "Discovery", "JUnit" }) |
Member
There was a problem hiding this comment.
The order is important here.
Contributor
Author
|
Thanks, yes of course, its always good to mark rejected stuff for the future. |
Pankraz76
changed the title
LexicographicalAnnotationAttributeListingLexicographicalAnnotationAttributeListing
Pankraz76
force-pushed
the
LexicographicalAnnotationListing--extend-errorprone
branch
from
afcad28 to
e473a09
Compare
marcphilipp
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations