This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Protect against a potential timing error in the model creation logic#322
Merged
Protect against a potential timing error in the model creation logic#322
Conversation
(c) Copyright IBM Corp. 2016
Collaborator
Author
|
/cc @SylvainCorlay |
Contributor
|
Tested this and it looks to have resolved a main issue that was hindering system tests, #206. A timing issue related to channel initialization messages. LGTM |
This was referenced Apr 28, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was due to the following:
widget_manager.new_widget(...).then(function(model){...})jupyter.widgetsmodel.once("comm:close")it is too lateThis PR is protecting in the callback and checking if the model's comm is still registered in the CommManager. This give me a chance to kick off the retry logic directly.