feat: add Z.AI GLM-4.7 support #502
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71c86f3d42
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } else if model_provider_id.eq_ignore_ascii_case("zai") { | ||
| model_provider = model_providers | ||
| .get("openai") | ||
| .ok_or_else(|| { | ||
| std::io::Error::new( |
There was a problem hiding this comment.
This branch forces model_provider_id to openai whenever the current provider is zai and the model is not glm-4.7. That means a user who normally runs with another provider (e.g., oss/openrouter) and briefly switches to glm-4.7 will be silently switched to OpenAI when they select any other model, and that provider choice gets persisted. For models that are only available on the original provider, requests will now be routed to the wrong backend and can fail. Consider restoring the previous provider (or the config default) instead of hardcoding OpenAI here, or only reverting when the provider was auto-set for glm-4.7.
Useful? React with 👍 / 👎.
1 participant
Summary
Usage
To use GLM-4.7, export your API key before running Code:
export Z_AI_API_KEY="ZAI-API-KEY"
Uses GLM OpenAI endpoint. Streaming doesn't work.