forked from bitpay/bitcore
-
Notifications
You must be signed in to change notification settings - Fork 0
WIP. Feat: Eth for insight #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rastajpa
wants to merge
52
commits into
justinkook:feature/eth-bws
Choose a base branch
from
rastajpa:feat/eth-insight
base: feature/eth-bws
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ush to convertedTx only if txid, from, and to are different, added 0x prefix to properties
…fix conditional for valid block id for api/.../block/blockId to validate 66 char eth blockIds
…needs to be an array, added error property to parent transaction object
…by lowercase address, added eth transform for streamWalletTransactions
…, complete block rewards
…1.1 to 2.5.1 for BWC package.json devDependency
…hanged Bitcore_[this.coin] to Bitcore_.btc
… into feature/eth-bws
…crypto-wallet-core to validate ethereum address, removed global.console.logs
… derivation verify and checkAddress verify in api.js
…then bc.getBalance
… of error component
46c1177 to
d48a253
Compare
justinkook
pushed a commit
that referenced
this pull request
Sep 17, 2019
FIX: request function name
justinkook
pushed a commit
that referenced
this pull request
Jan 10, 2020
Add blocks to getFee return object to match bws estimateFee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insight:
*There are still things to add and correct. I will continue working this PR when ETH is almost ready.