fix(pdm): Ignore some dependencies with markers that are not met by any target enviroment#146
Open
gfringeli wants to merge 1 commit intojvolkman:mainfrom
Open
Conversation
…ny target enviroment under the assumption that pdm creates consistent lock files
gfringeli
force-pushed
the
fix/pdm/unmet-markers-for-any-target
branch
from
e7e5257 to
087f793
Compare
|
I think this solution is reasonable: Under the assumption that the provided PDM lockfile is "correct", then any such missing dependency must be due to the dependency not being needed. At least under this assumption, the raised exception is exclusively triggering false positives, so removing it strictly improves the situation. |
Contributor
|
This fixes a problem I have too with pytest having an optional dep on Python <3.11. I agree this is reasonable given that we should assume PDM lockfiles are correct, as @burnpanck said. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea to improve (not perfectly solve) the situation described in #115.