Add Windows specific paths for python executable and site-packages for wheel_builder.py#204
Open
LaurenceTews wants to merge 1 commit intojvolkman:mainfrom
Open
Add Windows specific paths for python executable and site-packages for wheel_builder.py#204LaurenceTews wants to merge 1 commit intojvolkman:mainfrom
LaurenceTews wants to merge 1 commit intojvolkman:mainfrom
Conversation
LaurenceTews
force-pushed
the
wheel_builder_windows_paths
branch
from
9b249db to
b3f22f1
Compare
LaurenceTews
force-pushed
the
wheel_builder_windows_paths
branch
from
b3f22f1 to
10e836e
Compare
Owner
|
IIRC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working towards adding proper windows support when building wheels/libs.
There is a 3rd issue that the existing tests get caught up on, which is that
importlib.import_module(sysconfigdata_name).build_time_varsdoesn't work on Windows. I wondered ifsysconfig.get_config_vars()could be used instead, which is cross-plat. I didn't see a difference in the resultingtarget_sysconfig_varsvalues from the testing I did on macOS and linux, but perhaps there's a good reason for using the internal API.