use absolute replacement paths in wheel builder#207
Open
matt-sm wants to merge 1 commit intojvolkman:mainfrom
Open
use absolute replacement paths in wheel builder#207matt-sm wants to merge 1 commit intojvolkman:mainfrom
matt-sm wants to merge 1 commit intojvolkman:mainfrom
Conversation
found this when trying to build cffi with our custom hermetic cc toolchain. The relative paths generated by execroot_prefix() dont resolve correctly from that directory, causing linker errors when trying to find system libraries like libm and libc in the hermetic toolchains sysroot.
Owner
|
Looks like this may be related to #104. Is there an easy reproduction? Long ago I used absolute paths everywhere, but at some point I tried to make everything relative to increase reproducibility, as I kept finding absolute path names in built binaries. So I hesitate to go back, but maybe there's a better strategy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this when trying to build cffi with our custom hermetic cc toolchain.
The relative paths generated by execroot_prefix() dont resolve correctly from that directory, causing linker errors when trying to find system libraries like libm and libc in the hermetic toolchains sysroot.