Add support for Poetry platform-specific URL dependencies#210
Open
dududko wants to merge 1 commit intojvolkman:mainfrom
Open
Add support for Poetry platform-specific URL dependencies#210dududko wants to merge 1 commit intojvolkman:mainfrom
dududko wants to merge 1 commit intojvolkman:mainfrom
Conversation
This change enables rules_pycross to handle Poetry lock files with
platform-specific wheel URLs, such as PyTorch CPU wheels from different
indexes for different platforms.
Changes:
- Handle list-based dependencies in pyproject.toml (platform-specific URLs)
- Extract source URLs from lock file entries with `type = "url"`
- Merge wheel files from packages with same name but different versions
(e.g., torch@2.2.2 and torch@2.2.2+cpu) into a single package entry
This allows rules_pycross to select the correct wheel at build time based
on the target platform, which is essential for Remote Build Execution (RBE)
where different executors may need different platform-specific wheels.
Example pyproject.toml syntax now supported:
torch = [
{markers = "sys_platform == 'darwin'", url = "https://.../torch-2.2.2-macosx.whl"},
{markers = "sys_platform == 'linux'", url = "https://.../torch-2.2.2+cpu-linux.whl"},
]
Fixes: jvolkman#34
Owner
|
Thanks @dududko, sorry for the delay. One question - are you doing anything with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables rules_pycross to handle Poetry lock files with platform-specific wheel URLs, such as PyTorch CPU wheels from different indexes for different platforms.
Changes:
type = "url"This allows rules_pycross to select the correct wheel at build time based on the target platform, which is essential for Remote Build Execution (RBE) where different executors may need different platform-specific wheels.
Example pyproject.toml syntax now supported:
Fixes: #34