poetry: Skip packages with directory source in lockfile

[sin-ack]

Path dependencies are apparently added to poetry.lock as directory-sourced packages, and this was causing issues.

This fixes the following error:

Traceback (most recent call last):
  File ".../tools/poetry_translator.py", line 333, in <module>
    main(parse_flags())
  File ".../tools/poetry_translator.py", line 274, in main
    lock_set = translate(
               ^^^^^^^^^^
  File ".../tools/poetry_translator.py", line 204, in translate
    files = files_by_package_name[package_listed_name]
            ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
KeyError: 'path-dependency'

[njlr]

Given that skip is probably not the expected behavior, should this be behind a flag?

    directory_deps = "ignore",

[sin-ack]

It's the expected behavior since we do the same for path dependencies listed in pyproject.toml:

rules_pycross/pycross/private/tools/poetry_translator.py

Lines 149 to 151 in f0da947

	if "path" in pin_info:
	# Skip path dependencies.
	continue

[sin-ack]

(Though I agree that the established behavior can be surprising, so I could create a separate issue for that if you'd like. This one fixes the immediate build failure.)

[njlr]

(Though I agree that the established behavior can be surprising, so I could create a separate issue for that if you'd like. This one fixes the immediate build failure.)

Not my repo, just a user 🙂

[jvolkman]

Just for my understanding, do you have a small example that causes this scenario?

[sin-ack]

Just for my understanding, do you have a small example that causes this scenario?

Created one here: https://github.com/sin-ack/pycross-pr213-repro/