changed the wrapping function for HTML-bold and italic

[keshav234156]

Concerns publiclab/PublicLab.Editor#307

[keshav234156]

Hi have made the new wrapping function for bold, so that other modules are undisturbed It should most probably fix the publiclab/PublicLab.Editor#307 and may also cause some other bugs due to changes. So need to test it with different test cases as much as possible.

Another thing is that to exit out of module we need to press hotkey ie Ctrl + B for bold and
-> after that. Though -> may look inconsistent but that because we are using Zero width space, which I believe has its own pros and cons and that was the only solution that I could think of to exit out of code module

[keshav234156]

cc: @jywarren @emilyashley @VladimirMikulic @Shreyaa-s @NitinBhasneria @Shulammite-Aso

[keshav234156]

Mostly this part of code was changed: https://github.com/jywarren/woofmark/pull/1/files#diff-723d030cca36e1fdbae13e84f3ac27b9R20-R40

[VladimirMikulic]

Good, but needs to be documented for future devs.

[keshav234156]

@VladimirMikulic Will surely do that, just trying now to get it tested with as much as possible with manual test cases

[Shulammite-Aso]

What is -> please?🙈 Enter??

Also, can you add a GIF of how the changes now works?

Thanks😆

[keshav234156]

What is -> please? Enter??

Also, can you add a GIF of how the changes now works?

Thanks

-> is Right arrow. Will make GIF soon

[keshav234156]

@Shulammite-Aso @NitinBhasneria @Shreyaa-s Please review and try to test it with as much as possible with manual test cases

[NitinBhasneria]

@keshav234156 it is a little difficult thing to understand all your changes. As @Shulammite-Aso said can you make the gif of the changes so that we can particularly check on the changes and its effect.
Thank you

[jywarren]

Oh interesting! Are you able to publish this on your gh-pages branch so we can try it out live? And, can you clarify about needing ctrl-B AND ->? why not just ->?

Thank you!

[jywarren]

Can you link us to the general wrapping() function for comparison? Thanks!

[keshav234156]

https://github.com/jywarren/woofmark/blob/master/src/html/wrapping.js

[keshav234156]

@jywarren I tried deploying gh-page at https://keshav234156.github.io/woofmark-testing/examples/index.html But there is an error.Can you please help me to figure it out?

[keshav234156]

@jywarren wrapping function is only called when we press the respective hotkey, for bold its Ctrl + B and we need to press -> as we have added zero width space ie &#8203. This was the only way I found to exit out of the module.

[keshav234156]

[keshav234156]

@Shreyaa-s @NitinBhasneria @Shulammite-Aso any changes except documenting it.

[cypherean]

Since you're familiar with this part of the code, please have a look at this discussion and see if you can answer some of these questions publiclab/PublicLab.Editor#457. Any input would be appreciated! Thanks!

[jywarren]

This is looking great. In keeping with our idea of maintaining our own branch, would you be able to open this against jywarren/woofmark's plots2 branch, so that we have the master branch here still tracking the upstream bevacqua/woofmark? Does that make sense? I think it does but please correct me if you have a better idea, thank you!!!

[keshav234156]

This is looking great. In keeping with our idea of maintaining our own branch, would you be able to open this against jywarren/woofmark's plots2 branch, so that we have the master branch here still tracking the upstream bevacqua/woofmark? Does that make sense? I think it does but please correct me if you have a better idea, thank you!!!

ok,made a new PR #4

[keshav234156]

Since you're familiar with this part of the code, please have a look at this discussion and see if you can answer some of these questions publiclab/PublicLab.Editor#457. Any input would be appreciated! Thanks!

will take a look!!

[jywarren]

Deferring to copy of this in #4, moving over there!