Skip to content

Removed default parameters from implementation file#1

Open
kpochwala wants to merge 1 commit intomainfrom
improvement/no_warnings
Open

Removed default parameters from implementation file#1
kpochwala wants to merge 1 commit intomainfrom
improvement/no_warnings

Conversation

@kpochwala
Copy link

Default parameters should only be defined in the function declaration.

Without that platformio refuses to build with -Werror:

.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:34:44: error: default argument given for parameter 2 of 'ezLED::ezLED(int, int)' [-fpermissive]
 ezLED::ezLED(int pin, int mode = CTRL_ANODE) {
                                            ^
In file included from .pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:32:
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.h:89:3: note: previous specification in 'ezLED::ezLED(int, int)' here
   ezLED(int pin, int mode = CTRL_ANODE);
   ^~~~~
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:81:47: error: default argument given for parameter 1 of 'void ezLED::turnON(long unsigned int)' [-fpermissive]
 void ezLED::turnON(unsigned long delayTime = 0) {
                                               ^
In file included from .pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:32:
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.h:90:8: note: previous specification in 'void ezLED::turnON(long unsigned int)' here
   void turnON(unsigned long delayTime = 0);
        ^~~~~~
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:95:48: error: default argument given for parameter 1 of 'void ezLED::turnOFF(long unsigned int)' [-fpermissive]
 void ezLED::turnOFF(unsigned long delayTime = 0) {
                                                ^
In file included from .pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:32:
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.h:91:8: note: previous specification in 'void ezLED::turnOFF(long unsigned int)' here
   void turnOFF(unsigned long delayTime = 0);
        ^~~~~~~
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:109:47: error: default argument given for parameter 1 of 'void ezLED::toggle(long unsigned int)' [-fpermissive]
 void ezLED::toggle(unsigned long delayTime = 0) {
                                               ^
In file included from .pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:32:
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.h:92:8: note: previous specification in 'void ezLED::toggle(long unsigned int)' here
   void toggle(unsigned long delayTime = 0);
        ^~~~~~
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:125:95: error: default argument given for parameter 4 of 'void ezLED::fade(int, int, long unsigned int, long unsigned int)' [-fpermissive]
 void ezLED::fade(int fadeFrom, int fadeTo, unsigned long fadeTime, unsigned long delayTime = 0) {
                                                                                               ^
In file included from .pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:32:
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.h:94:8: note: previous specification in 'void ezLED::fade(int, int, long unsigned int, long unsigned int)' here
   void fade(int fadeFrom, int fadeTo, unsigned long fadeTime, unsigned long delayTime = 0);
        ^~~~
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:141:91: error: default argument given for parameter 3 of 'void ezLED::blink(long unsigned int, long unsigned int, long unsigned int)' [-fpermissive]
 void ezLED::blink(unsigned long onTime, unsigned long offTime, unsigned long delayTime = 0) {
                                                                                           ^
In file included from .pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:32:
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.h:96:8: note: previous specification in 'void ezLED::blink(long unsigned int, long unsigned int, long unsigned int)' here
   void blink(unsigned long onTime, unsigned long offTime, unsigned long delayTime = 0);
        ^~~~~
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:159:124: error: default argument given for parameter 4 of 'void ezLED::blinkInPeriod(long unsigned int, long unsigned int, long unsigned int, long unsigned int)' [-fpermissive]
 void ezLED::blinkInPeriod(unsigned long onTime, unsigned long offTime, unsigned long blinkTime, unsigned long delayTime = 0) {
                                                                                                                            ^
In file included from .pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:32:
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.h:97:8: note: previous specification in 'void ezLED::blinkInPeriod(long unsigned int, long unsigned int, long unsigned int, long unsigned int)' here
   void blinkInPeriod(unsigned long onTime, unsigned long offTime, unsigned long blinkTime, unsigned long delayTime = 0);
        ^~~~~~~~~~~~~
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:179:132: error: default argument given for parameter 4 of 'void ezLED::blinkNumberOfTimes(long unsigned int, long unsigned int, unsigned int, long unsigned int)' [-fpermissive]
 void ezLED::blinkNumberOfTimes(unsigned long onTime, unsigned long offTime, unsigned int numberOfTimes, unsigned long delayTime = 0) {
                                                                                                                                    ^
In file included from .pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.cpp:32:
.pio/libdeps/kabot-esp32-s3-n16r8/ezLED/src/ezLED.h:98:8: note: previous specification in 'void ezLED::blinkNumberOfTimes(long unsigned int, long unsigned int, unsigned int, long unsigned int)' here
   void blinkNumberOfTimes(unsigned long onTime, unsigned long offTime, unsigned int numberOfTimes, unsigned long delayTime = 0);
        ^~~~~~~~~~~~~~~~~~
Compiling .pio/build/kabot-esp32-s3-n16r8/lib91b/ESP32_Servo/ESP32_Servo.cpp.o
*** [.pio/build/kabot-esp32-s3-n16r8/lib154/ezLED/ezLED.cpp.o] Error 1

@kpochwala kpochwala requested a review from jjkolasa April 30, 2023 02:07
@kpochwala kpochwala force-pushed the improvement/no_warnings branch from 233c126 to 58242b4 Compare April 30, 2023 02:10
@kpochwala kpochwala force-pushed the improvement/no_warnings branch from 58242b4 to 50cb45f Compare April 30, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant