Fix trainer related stuff #92

kadeshar · 2026-02-10T19:15:19Z

Pull Request

Describe what this change does and why it is needed...

Design Philosophy

We prioritize stability, performance, and predictability over behavioral realism.
Complex player-mimicking logic is intentionally limited due to its negative impact on scalability, maintainability, and
long-term robustness.

Excessive processing overhead can lead to server hiccups, increased CPU usage, and degraded performance for all
participants. Because every action and
decision tree is executed per bot and per trigger, even small increases in logic complexity can scale poorly and
negatively affect both players and
world (random) bots. Bots are not expected to behave perfectly, and perfect simulation of human decision-making is not a
project goal. Increased behavioral
realism often introduces disproportionate cost, reduced predictability, and significantly higher maintenance overhead.

Every additional branch of logic increases long-term responsibility. All decision paths must be tested, validated, and
maintained continuously as the system evolves.
If advanced or AI-intensive behavior is introduced, the default configuration must remain the lightweight decision
model. More complex behavior should only be
available as an explicit opt-in option, clearly documented as having a measurable performance cost.

Principles:

Stability before intelligence
A stable system is always preferred over a smarter one.
Performance is a shared resource
Any increase in bot cost affects all players and all bots.
Simple logic scales better than smart logic
Predictable behavior under load is more valuable than perfect decisions.
Complexity must justify itself
If a feature cannot clearly explain its cost, it should not exist.
Defaults must be cheap
Expensive behavior must always be optional and clearly communicated.
Bots should look reasonable, not perfect
The goal is believable behavior, not human simulation.

Before submitting, confirm that this change aligns with those principles.

Feature Evaluation

Please answer the following:

Describe the minimum logic required to achieve the intended behavior?
Describe the cheapest implementation that produces an acceptable result?
Describe the runtime cost when this logic executes across many bots?

How to Test the Changes

Step-by-step instructions to test the change
Any required setup (e.g. multiple players, bots, specific configuration)
Expected behavior and how to verify it

Complexity & Impact

Does this change add new decision branches?

- No
- Yes (explain below)

Does this change increase per-bot or per-tick processing?

- No
- Yes (describe and justify impact)

Could this logic scale poorly under load?

- No
- Yes (explain why)

Defaults & Configuration

Does this change modify default bot behavior?

- No
- Yes (explain why)

If this introduces more advanced or AI-heavy logic:

- Lightweight mode remains the default
- More complex behavior is optional and thereby configurable

AI Assistance

Was AI assistance (e.g. ChatGPT or similar tools) used while working on this change?

- No
- Yes (explain below)

If yes, please specify:

AI tool or model used (e.g. ChatGPT, GPT-4, Claude, etc.)
Purpose of usage (e.g. brainstorming, refactoring, documentation, code generation)
Which parts of the change were influenced or generated
Whether the result was manually reviewed and adapted

AI assistance is allowed, but all submitted code must be fully understood, reviewed, and owned by the contributor.
Any AI-influenced changes must be verified against existing CORE and PB logic. We expect contributors to be honest
about what they do and do not understand.

Final Checklist

- Stability is not compromised
- Performance impact is understood, tested, and acceptable
- Added logic complexity is justified and explained
- Documentation updated if needed

Notes for Reviewers

Anything that significantly improves realism at the cost of stability or performance should be carefully discussed
before merging.

…eless checks and variables

…al action's logic

…fix-trainer-related-stuff

…rmance

…rainerSpells

Copilot

Pull request overview

This PR refactors “trainer” behavior/configuration for playerbots by simplifying the train trigger logic, adding a reusable “can train” value, and reworking the trainer action to support explicit target selection (master vs bot) and trainer validation.

Changes:

Replaced AiPlayerbot.AutoTrainSpells (string) with AiPlayerbot.AllowLearnTrainerSpells (bool) and updated config initialization + conf template.
Added CanTrainValue and wired it into ValueContext, then simplified RpgTrainTrigger to rely on that value.
Refactored TrainerAction and RpgTrainAction to centralize validation/affordability checks and streamline spell iteration/learning.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/PlayerbotAIConfig.h	Replaces `autoTrainSpells` string with `allowLearnTrainerSpells` bool.
src/PlayerbotAIConfig.cpp	Loads the new `AiPlayerbot.AllowLearnTrainerSpells` config option.
src/Ai/World/Rpg/Action/NewRpgBaseAction.cpp	Simplifies questgiver interaction checks (removes trainer-related logic from this path).
src/Ai/Base/ValueContext.h	Registers new `"can train"` value creator.
src/Ai/Base/Value/MaintenanceValues.h	Adds `CanTrainValue` declaration.
src/Ai/Base/Value/MaintenanceValues.cpp	Implements `CanTrainValue` based on free money for spells.
src/Ai/Base/Value/LogLevelValue.h	Adds missing include for logging common definitions.
src/Ai/Base/Value/BudgetValues.cpp	Refactors train/repair cost calculations; changes trainer scan logic.
src/Ai/Base/Trigger/RpgTriggers.h	Removes `RpgTrainTrigger::IsTrainerOf` declaration.
src/Ai/Base/Trigger/RpgTriggers.cpp	Simplifies train trigger to use `"can train"` and basic trainer flag check.
src/Ai/Base/Actions/TrainerAction.h	Refactors trainer action interface and private helpers.
src/Ai/Base/Actions/TrainerAction.cpp	Refactors execution/validation/learning flow and target selection logic.
src/Ai/Base/Actions/RpgSubActions.h	Adds `isPossible/isUseful` overrides for `RpgTrainAction`.
src/Ai/Base/Actions/RpgSubActions.cpp	Implements trainer affordability/teachability checks for RPG train action.
conf/playerbots.conf.dist	Updates documentation and default for `AiPlayerbot.AllowLearnTrainerSpells`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-10T19:22:11Z

src/Ai/Base/Actions/TrainerAction.cpp

+    Creature* target = GetTarget()->ToCreature();
+    if (!target)
+        return false;


GetTarget() can return nullptr (no selection by bot/master), but GetTarget()->ToCreature() dereferences it unconditionally. This can crash in Execute() (and the same pattern is used in isUseful() / isPossible()). Store the Unit* returned by GetTarget() and null-check it before calling ToCreature()/accessing it.

Copilot · 2026-02-10T19:22:12Z

src/Ai/Base/Actions/TrainerAction.cpp

+    if (trainer->GetSpells().empty())
    {
-        if (spellInfo->Effects[j].Effect == SPELL_EFFECT_LEARN_SPELL)
-        {
-            uint32 learnedSpell = spellInfo->Effects[j].TriggerSpell;
-            if (!bot->HasSpell(learnedSpell))
-            {
-                bot->learnSpell(learnedSpell);
-                learned = true;
-            }
-        }
+        // Not sure why we need to say anything, especially w/o master
+        botAI->TellError("No spells can be learned from this trainer");
+        return false;


isPossible() should ideally be side-effect free, but it calls botAI->TellError(...). Since isPossible() is used during regular action selection (not just on explicit command execution), this can generate repeated error notifications. Consider moving this message to Execute() (only when the trainer action is actually run), or gate it behind an explicit player command / debug mode.

Copilot · 2026-02-10T19:22:12Z

src/Ai/Base/Value/BudgetValues.cpp

+        if (!(itr->second.npcflag & UNIT_NPC_FLAG_TRAINER))
+            continue;



TrainCostValue::Calculate() now skips creature templates unless npcflag contains UNIT_NPC_FLAG_TRAINER. Other parts of the codebase iterate all templates and rely on sObjectMgr->GetTrainer(entry) (e.g., PlayerbotFactory::InitAvailableSpells()), so this filter can cause train cost to be undercounted for trainers that exist but don't have this specific flag set (or use other trainer-related flags). Consider removing the npcflag filter, or expanding it to include all trainer-related flags you expect (class/profession/etc).

Suggested change

if (!(itr->second.npcflag & UNIT_NPC_FLAG_TRAINER))

continue;

…cessing isPossible checks

…thod

… list

privatecore and others added 11 commits February 2, 2026 13:45

Fix rest of trainers' related stuff + codestyle changes and corrections

1307023

Merge branch 'master' into fix-trainer-related-stuff

3ed243d

Update NewRpgBaseAction::CanInteractWithQuestGiver method - remove us…

c51952d

…eless checks and variables

Update RpgTrainAction's isUseful and isPossible methods to fit origin…

35a044c

…al action's logic

Merge remote-tracking branch 'origin/fix-trainer-related-stuff' into …

ff14cf6

…fix-trainer-related-stuff

Fix copy-paste error after recent changes - sonarqube ftw!

7466b76

Update and optimize TrainCostValue::Calculate method for better perfo…

6a3c623

…rmance

Fix clangd complains about undeclared identifiers

c1f8fb2

Implement 'can train' context value calculation + fix clangd complains

7c5e069

Rewrite TrainerAction methods + update autoTrainSpells -> allowLearnT…

028bcbc

…rainerSpells

Partly restore previous behavior if the bot has the gold cheat

0444949

Copilot AI review requested due to automatic review settings February 10, 2026 19:15

Copilot started reviewing on behalf of kadeshar February 10, 2026 19:15 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

privatecore added 3 commits February 11, 2026 21:42

Fix RpgTrainAction's isUseful checks + use creature template when pro…

ff97856

…cessing isPossible checks

Fix TrainerAction's isUseful checks + add GetCreatureTarget helper me…

f394632

…thod

Remove tellError action when processing trainers with an empty spells…

cdfa9e2

… list

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix trainer related stuff #92

Fix trainer related stuff #92

Uh oh!

kadeshar commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		if (!(itr->second.npcflag & UNIT_NPC_FLAG_TRAINER))
		continue;

Fix trainer related stuff #92

Are you sure you want to change the base?

Fix trainer related stuff #92

Uh oh!

Conversation

kadeshar commented Feb 10, 2026

Pull Request

Design Philosophy

Feature Evaluation

How to Test the Changes

Complexity & Impact

Defaults & Configuration

AI Assistance

Final Checklist

Notes for Reviewers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants