Fixed the error message shown when a PID is not provided. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is still a duplicate line of code that needs to be addressed.
kaiwan
requested changes
Oct 20, 2025
Owner
kaiwan
left a comment
kaiwan
left a comment
There was a problem hiding this comment.
Kindly check out the review comment & address, thanks
| shift $((OPTIND-1)) | ||
|
|
||
| [[ ${PID} -eq 0 ]] && err 0 "Error: Invalid PID (must be a positive integer)" | ||
| [[ ${PID} -eq 0 ]] && err 0 "Specifying a valid PID with -p|--pid=<PID> is mandatory" |
Owner
There was a problem hiding this comment.
Right; can you make the err msg as:
"Specifying a valid PID with -p <PID> or --pid=<PID> is mandatory"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the PID is passed to the script like this:
The script outputs a confusing message:
The message was changed to this one:
Note: There is still a duplicate line of code that needs to be addressed.