improvement for getting correct submenu's height (when menu's height doesn't equal to submenu's) #51
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added an option to set submenu's max height so it gets the correct height, rather than always using menu's height (in some cases, menu's height is less than submenu's); added leaveMenuTimeoutId, for not deactivating submenu if mouse is moving to submenu but has exited menu.
|
can u send us the code for height |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks for bringing us the great plugin! I've used it in my project and it works as expected. However, I found it had some issue for getting correct submenu's height when it doesn't equal to menu's (submenu is taller than menu for instance). In that case, the calculation of the mouse path triangle was not accurate。
I added an option to set submenu's max height so it gets the correct
height, rather than always using menu's height;
added leaveMenuTimeoutId, for not deactivating submenu if mouse is
moving to submenu but has exited menu.