Make dataset alias comparisons case-insensitive

[rmn-boiko]

Description

Closes: Make dataset names and aliases comparisons case-insensitive

Checklist before requesting a review

• CHANGELOG.md updated
• API changes are backwards-compatible
• Workspace layout changes include a migration
• Documentation update PR: <link or N/A>
• Dataset pipelines update scheduled if needed

[zaychenko-sergei]

1. I can see that you've touched the casing of accounts as well. On today account names are case-sensitive in all implementations of AuthenticationProvider trait. These would need to take into account that "Wasya" and "wasya" are the same accounts. Before you start digging into this direction, plz make a quick check if GitHub accounts are case-sensitive or not. It seems they are case-insensitive, but double check.

2. I think what is done in the repositories implementation is not enough. You need to make methods like resolve_dataset_ref to be case-insensitive as well. Note that in multi-tenant repos account names are used in datasets folder names, and in single-tenant local repo the dataset name is used as name of folder. Basically, the entire infrastructure of dataset repositories should be lowercasing all objects and references. This, btw, would fix some potential bugs on Windows platform, where file names are case-insensitive.

3. I'd like to see more tests. Repository changes for sure. Might be interesting to ensure our HTTP and GraphQL APIs are properly aligned with casing - in HTTP case you need to be careful with URL matching middlewares.

[s373r]

a minor comment added

[zaychenko-sergei]

Summary on the decisive discussion:

• a note on case sensitivity of name components was added explicitly to ODF protocol
• we should preserve original casing of the name components everywhere, but make case-insensitive lookups and case-insensitive name uniqueness checks, as well as ignore-case patterns
• note that RepoName component is also important, this wasn't mentioned before, as we've only touched DatasetName and AccountName.

[sergiimk]

Things mostly look good, but I have doubts in dataset_repository_local_fs.rs. I suggested one extra test to see if my worries are correct.

Sorry you had to deal with all the ugly complexity of the local fs repo - I really hope it will soon go away after we stop storing datasets in account/name directories.

[zaychenko-sergei]

Problem:

I would expect that filter works without case sensitivity

[zaychenko-sergei]

A similar problem