Skip to content

Fixes issue #10, whereby an update can happen before a mount #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajmas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes issue #10, whereby an update can happen before a mount #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d55ae6
Fixes issue #10, whereby an update happens before a mount
ajmas Jul 18, 2017
ad73a12
logic change in componentDidUpdate
ajmas Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ReactBubbleChart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,10 @@ class ReactBubbleChart extends React.Component {

/** When we update, update our friend, the bubble chart */
componentDidUpdate() {
this.bubbleChart.update(this.getDOMNode(), this.getChartState());
// Apparently updates can happen before a mount, so deal with this scenario
if (this.bubbleChart) {
this.bubbleChart.update(this.getDOMNode(), this.getChartState());
}
}

/** Define what props get passed down to the d3 chart */
Expand Down