Skip to content

Width and Height aligning bugfix #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishnuys wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Width and Height aligning bugfix #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88da517
Resize according to height and width
vishnuys Jan 13, 2017
9a33d56
Small bugfix
vishnuys Jan 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/ReactBubbleChartD3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ import d3 from 'd3';
* duration
* delay
*/

var setWidth = 300;
var setHeight = 300;

export default class ReactBubbleChartD3 {
constructor(el, props = {}) {
this.legendSpacing = typeof props.legendSpacing === 'number' ? props.legendSpacing : 3;
Expand All @@ -49,7 +53,7 @@ export default class ReactBubbleChartD3 {

// create an <svg> and <html> element - store a reference to it for later
this.svg = d3.select(el).append('svg')
.attr('class', 'bubble-chart-d3')
.attr({className:'bubble-chart-d3', width: setWidth, height: setHeight})
.style('overflow', 'visible');
this.html = d3.select(el).append('div')
.attr('class', 'bubble-chart-text')
Expand All @@ -58,10 +62,11 @@ export default class ReactBubbleChartD3 {
.style('right', 0)
.style('margin-left', 'auto')
.style('margin-right', 'auto');
this.legend = d3.select(el).append('svg')
.attr('class', 'bubble-legend')
.style('overflow', 'visible')
.style('position', 'absolute');
this.legend = d3.select(el)
//.append('svg')
//.attr('class', 'bubble-legend')
//.style('overflow', 'visible')
//.style('position', 'absolute');
this.tooltip = this.html.append('div')
.attr('class', 'tooltip')
.style('position', 'absolute')
Expand Down