Skip to content

Conversation

@MrCreosote
Copy link
Member

No description provided.

@MrCreosote MrCreosote requested a review from briehl January 22, 2026 23:16
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.41%. Comparing base (77a783a) to head (87a3b1e).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #511   +/-   ##
==========================================
  Coverage      93.40%   93.41%           
- Complexity      2158     2159    +1     
==========================================
  Files            129      129           
  Lines           7615     7622    +7     
  Branches        1170     1170           
==========================================
+ Hits            7113     7120    +7     
  Misses           459      459           
  Partials          43       43           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCreosote
Copy link
Member Author

MrCreosote commented Jan 22, 2026

Hmm, looks like images don't push without a merge

EDIT: It's because the PR is going to develop vs. main

Copy link
Collaborator

@dauglyon dauglyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM... the globus change looks good too but we should double check login still works in CI before pushing to prod. Don't see any reason it wouldn't.

@MrCreosote
Copy link
Member Author

MrCreosote commented Jan 26, 2026

But testing in prod is all the rage nowadays

@MrCreosote MrCreosote merged commit 0f04ba5 into develop Jan 26, 2026
12 checks passed
@MrCreosote MrCreosote changed the title CDM-481: Allow non-Login tokens to inherit MFA status CDM-461: Allow non-Login tokens to inherit MFA status Jan 26, 2026
@MrCreosote MrCreosote deleted the dev-mfa branch January 26, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants