Replace download-tool.sh with µget #128
Merged
+946
−334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note-none
Contributor
|
LGTM label has been added. DetailsGit tree hash: becfa60b41a1118cbf776aae514b25f56fa0b4ac |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This applies the same refactoring as we've done in kcp, api-syncagent and multicluster-provider already, replacing one download script with another, much better one. This PR also fixes some small other issues here and there that I randomly found.
Note that I had to include a small hack in µget. Since we are downloading an old kcp code-generator, we have to bump golang/x/tools or else it won't compile on Go 1.25+. This has not caused issues because the old download script just did a "go get", but µget like all other Go package managers creates a temporary module.
What Type of PR Is This?
/kind cleanup
Release Notes