Handle caBundleSecretRef in the shard controller #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the handling of the provided secret in the shards spec at .spec.caBundleSecretRef to the shards external logical cluster kubeconfig. This behavior is described in the CRD but is currently not implemented. This leads to issues if the externalHostname does not have the same certificate issuer as the serverCA (e.g. front-proxy with lets encrypt certificate and the rootShard & shard with self signed certificates).
The controller tests are extended to test for the correct path in the certificateAuthority property of the kubeconfig.
What Type of PR Is This?
/kind bug
Related Issue(s)
/
Release Notes