Skip to content

Conversation

@BergCyrill
Copy link

Summary

This PR adds the handling of the provided secret in the shards spec at .spec.caBundleSecretRef to the shards external logical cluster kubeconfig. This behavior is described in the CRD but is currently not implemented. This leads to issues if the externalHostname does not have the same certificate issuer as the serverCA (e.g. front-proxy with lets encrypt certificate and the rootShard & shard with self signed certificates).
The controller tests are extended to test for the correct path in the certificateAuthority property of the kubeconfig.

What Type of PR Is This?

/kind bug

Related Issue(s)

/

Release Notes

Fix usage of caBundleSecretRef in external logical cluster kubeconfig for shards resources similar to the rootShard behavior

…ClusterAdminKubeconfig

Signed-off-by: Cyrill Berg <cyrill.berg@bwi.de>
Signed-off-by: Cyrill Berg <cyrill.berg@bwi.de>
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. labels Dec 17, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot
Copy link
Contributor

Hi @BergCyrill. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants