backup: check if deviceidle.xml actually exists #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wight554
commented
Nov 22, 2021
wight554
commented
- to prevent file "no such file or directory" spam if it doesn't
* to prevent file no such file or directory spam if it doesn't
wight554
force-pushed
the
check-deviceidle
branch
from
795336c to
0581acc
Compare
kdrag0n
requested changes
Nov 23, 2021
|
|
||
| # Battery optimization | ||
| if grep -q "$app" /data/system/deviceidle.xml; then | ||
| if [[ -f /data/system/deviceidle.xml ]] && grep -q "$app" /data/system/deviceidle.xml; then |
Owner
There was a problem hiding this comment.
This could just be grep -q [...] 2> /dev/null, so there's no need for an extra check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.