Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Conversation

@stephaniexiao
Copy link
Collaborator

@stephaniexiao stephaniexiao commented Sep 19, 2020

Description of changes:

  • Standardized variable styles "itemId" -> "item_id"
  • Moved import statement to top
  • Added static variable to account for purchases above 250 for 17 reward points
  • Added an error log array to replace the raised ValueError
  • Simplified process log method: only general cases (for both customers with and without ids) and reward points cases
  • Removed unnecessary get_items_purchased method
  • Removed unnecessary comments
  • Removed unnecessary print statements

Which files were touched:

  • rewardPointsSystem.py

Notes for PMs:

  • Left a few comments in the code--not sure if they should be considered necessary or unnecessary

Relevant Issue: #1
Fixes #8

Copy link
Owner

@kelvinjue kelvinjue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work here! We'll be going over these during one of our meetings this week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean-up rewardsPointsSystem

3 participants